[PATCH] D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them.

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One small change needed, otherwise LGTM.



================
Comment at: llvm/cmake/config-ix.cmake:569
+    NINJA_VERSION VERSION_GREATER_EQUAL "1.9.0" AND
+    CMAKE_SYSTEM_NAME MATCHES "Darwin" AND
+    CMAKE_HOST_SYSTEM_VERSION VERSION_GREATER "15.6.0")
----------------
Instead of checking `CMAKE_SYSTEM_NAME` you should probably just check `CMAKE_HOST_APPLE`. Not that people really are targeting Darwin from other hosts, but `CMAKE_SYSTEM_NAME` is actually the target system not the host.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62172/new/

https://reviews.llvm.org/D62172