[PATCH] D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them.
Don Hinton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 09:45:47 PDT 2019
hintonda added a comment.
In D62172#1510515 <https://reviews.llvm.org/D62172#1510515>, @beanz wrote:
> It is silly that CMake doesn't expose the ninja version, but it is easy enough to get it. It should be something like:
>
> if(CMAKE_GENERATOR STREQUAL "Ninja")
> execute_process(COMMAND ${RunCMake_MAKE_PROGRAM} --version
> OUTPUT_VARIABLE ninja_version OUTPUT_STRIP_TRAILING_WHITESPACE)
> if(ninja_version VERSION_GREATER 1.8.2)
> set(ninja_greater_1_8_2 On)
> endif()
> endif()
>
>
> I know this is a bunch of seemingly odd boiler plate, but since we're working around tools bugs in non-LLVM tools which will hopefully someday be fixed, I'd like to restrict this fix to only places where we know the bug is present.
I already added it to llvm/cmake/config-ix.cmake. Please let me know if it looks okay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62172/new/
https://reviews.llvm.org/D62172
More information about the llvm-commits
mailing list