[PATCH] D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them.

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 09:37:40 PDT 2019


beanz added a comment.

It is silly that CMake doesn't expose the ninja version, but it is easy enough to get it. It should be something like:

  if(CMAKE_GENERATOR STREQUAL "Ninja")
    execute_process(COMMAND ${RunCMake_MAKE_PROGRAM} --version
        OUTPUT_VARIABLE ninja_version OUTPUT_STRIP_TRAILING_WHITESPACE)
    if(ninja_version VERSION_GREATER 1.8.2)
      set(ninja_greater_1_8_2 On)
    endif()
  endif()

I know this is a bunch of seemingly odd boiler plate, but since we're working around tools bugs in non-LLVM tools which will hopefully someday be fixed, I'd like to restrict this fix to only places where we know the bug is present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62172/new/

https://reviews.llvm.org/D62172





More information about the llvm-commits mailing list