[PATCH] D62112: [ORC] fix use-after-move. NFC
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 09:03:02 PDT 2019
dblaikie added a comment.
Hey @lhames - is this code tested? I guess they're only debug output, so might not be tested. (was the use-after-move likely to be UB (null deref, etc) or just likely to log not what was intended?)
Reckon it'd be suitable to not use "auto" for the N and/or ES variables? The "N" variable perhaps makes me more concerned than ES - because is it a string reference? (that might be invalidated by the move), a return by value (that then means it's reference extending, which is best avoided unless really needed), etc?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62112/new/
https://reviews.llvm.org/D62112
More information about the llvm-commits
mailing list