[PATCH] D62198: StructurizeCFG: Relax uniformity checks.

Tue May 21 08:42:13 PDT 2019

nhaehnle added a comment.

I'm personally not confident enough in this change to enable it unconditionally immediately. I think this should be guarded with an option.

================
Comment at: test/CodeGen/AMDGPU/control-flow-optnone.ll:18-19
 ; GCN: s_or_b64 exec, exec
-; GCN: v_cmp_eq_u32
-; GCN: s_cbranch_vccnz
+; GCN: s_cmp_eq_u32
+; GCN: s_cbranch_scc1
 ; GCN-NEXT: s_branch
----------------
I think this doesn't fit with what the test is actually trying to test. There's a comment above that says it wants to be changed to optnone. Perhaps better to change the run line accordingly?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62198/new/

https://reviews.llvm.org/D62198