[PATCH] D62166: [mips] Always check that `shift and add` optimization is efficient
Petar Avramovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 07:50:58 PDT 2019
Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/Target/Mips/MipsSEISelLowering.cpp:723
// constant multiply into. The number is approximately how many powers
// of two summed together that the constant can be broken down into.
+ //
----------------
This comment can be misleading. The number is approximately equal to the minimal number of powers of two that constant can be broken down to by adding or __subtracting__ them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62166/new/
https://reviews.llvm.org/D62166
More information about the llvm-commits
mailing list