[PATCH] D62063: CMake changes to get Windows self-host with PGO working

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 05:55:37 PDT 2019


russell.gallop updated this revision to Diff 200469.
russell.gallop added a comment.

Handle -fprofile-generate and -fcs-profile-generate options for self hosting as well.

This highlights two other problems with using those options for Windows self host builds.
1). -fprofile-generate and -fcs-profile-generate need clang_rt.profile adding with --dependent-lib in the driver (like https://reviews.llvm.org/D61742). I'll create a separate review for that.
2). Self hosting with -fprofile-generate hits a crash building CrashRecoveryContext.cpp. I'll try to report this.

But I believe that the cmake changes are okay.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62063/new/

https://reviews.llvm.org/D62063

Files:
  llvm/CMakeLists.txt
  llvm/cmake/modules/HandleLLVMOptions.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62063.200469.patch
Type: text/x-patch
Size: 3746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190521/e84b1c92/attachment.bin>


More information about the llvm-commits mailing list