[PATCH] D62170: Add --reproduce to lld/wasm.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 04:46:46 PDT 2019
ruiu marked 2 inline comments as done.
ruiu added inline comments.
================
Comment at: lld/test/wasm/reproduce.ll:9
+; RUN: tar xf repro.tar
+; RUN: ls repro/%t.dir/foo.o
+
----------------
sbc100 wrote:
> If you are trying to verify the contents here why not something more explicit like `tar t repro.tar | FileCheck %s -check-prefix=CONTENTS`?
Done.
================
Comment at: lld/wasm/InputFiles.cpp:58
return make<BitcodeFile>(MB, ArchiveName);
-
fatal("unknown file type: " + MB.getBufferIdentifier());
----------------
sbc100 wrote:
> Seems unrelated. Also, I kind of like the vertical separation here.
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62170/new/
https://reviews.llvm.org/D62170
More information about the llvm-commits
mailing list