[llvm] r361240 - [llvm-objdump] Make --disassemble-functions imply -d

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 04:05:46 PDT 2019


Author: grimar
Date: Tue May 21 04:05:46 2019
New Revision: 361240

URL: http://llvm.org/viewvc/llvm-project?rev=361240&view=rev
Log:
[llvm-objdump] Make --disassemble-functions imply -d

Fixes https://bugs.llvm.org/show_bug.cgi?id=41903

Patch by Mike Pozulp!

Differential revision: https://reviews.llvm.org/D62054

Added:
    llvm/trunk/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test
Modified:
    llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

Added: llvm/trunk/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test?rev=361240&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test (added)
+++ llvm/trunk/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test Tue May 21 04:05:46 2019
@@ -0,0 +1,22 @@
+## Check that --disassemble-functions implies --disassemble.
+# RUN: yaml2obj < %s | llvm-objdump - --disassemble-functions=main | FileCheck %s
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_X86_64
+Sections:
+  - Name:    .text
+    Type:    SHT_PROGBITS
+    Flags:   [ SHF_EXECINSTR ]
+    Content: 90
+Symbols:
+  - Name:    main
+    Type:    STT_FUNC
+    Section: .text
+...
+
+# CHECK: 0000000000000000 main:
+# CHECK-NEXT:        0: 90                            nop

Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=361240&r1=361239&r2=361240&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Tue May 21 04:05:46 2019
@@ -2032,7 +2032,8 @@ int main(int argc, char **argv) {
     ArchiveHeaders = FileHeaders = PrivateHeaders = Relocations =
         SectionHeaders = SymbolTable = true;
 
-  if (DisassembleAll || PrintSource || PrintLines)
+  if (DisassembleAll || PrintSource || PrintLines ||
+      (!DisassembleFunctions.empty()))
     Disassemble = true;
 
   if (!ArchiveHeaders && !Disassemble && DwarfDumpType == DIDT_Null &&




More information about the llvm-commits mailing list