[PATCH] D62146: FileCheck: Improve FileCheck variable terminology

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 02:09:01 PDT 2019


thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:314
+  /// and the value of numeric expression "N+1" at offset 6.
+  std::vector<FileCheckSubstitution *> Substitutions;
 
----------------
Self note: this needs to become a vector of std::unique_ptr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62146/new/

https://reviews.llvm.org/D62146





More information about the llvm-commits mailing list