[PATCH] D62170: Add --reproduce to lld/wasm.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 02:04:20 PDT 2019


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/reproduce.ll:9
+; RUN: tar xf repro.tar
+; RUN: ls repro/%t.dir/foo.o
+
----------------
If you are trying to verify the contents here why not something more explicit like `tar t repro.tar | FileCheck %s -check-prefix=CONTENTS`?


================
Comment at: lld/wasm/InputFiles.cpp:58
     return make<BitcodeFile>(MB, ArchiveName);
-
   fatal("unknown file type: " + MB.getBufferIdentifier());
----------------
Seems unrelated.  Also, I kind of like the vertical separation here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62170/new/

https://reviews.llvm.org/D62170





More information about the llvm-commits mailing list