[PATCH] D62170: Add --reproduce to lld/wasm.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 01:04:45 PDT 2019
ruiu marked 2 inline comments as done.
ruiu added inline comments.
================
Comment at: lld/wasm/Driver.cpp:31
+#include "llvm/Support/TarWriter.h"
#include "llvm/Support/TargetSelect.h"
----------------
grimar wrote:
> Unsorted.
It's actually sorted ASCIIbetically.
================
Comment at: lld/wasm/InputFiles.cpp:35
Optional<MemoryBufferRef> lld::wasm::readFile(StringRef Path) {
log("Loading: " + Path);
----------------
grimar wrote:
> Seems `Loading` should be lower case for conistency with `log` in `dumpInfo()` below.
Well, true, but we shouldn't fix that in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62170/new/
https://reviews.llvm.org/D62170
More information about the llvm-commits
mailing list