[PATCH] D62176: [CMake] Specify component for all target types

[Petr Hosek via Phabricator via llvm-commits]

phosek created this revision.
phosek added reviewers: mstorsjo, beanz, jschueller.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
phosek added a comment.

This fixes a bug introduced by D61425 <https://reviews.llvm.org/D61425>.


This addresses an issue introduced in r360230 which broke existing
use cases of LLVM_DISTRIBUTION_COMPONENTS since ARCHIVE and LIBRARY
target types are no longer handled as components.


Repository:
  rL LLVM

https://reviews.llvm.org/D62176

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -682,10 +682,9 @@
 
       install(TARGETS ${name}
               ${export_to_llvmexports}
-              LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX}
-              ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX}
-              RUNTIME DESTINATION bin
-              COMPONENT ${name})
+              LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX} COMPONENT ${name}
+              ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX} COMPONENT ${name}
+              RUNTIME DESTINATION bin COMPONENT ${name})
 
       if (NOT LLVM_ENABLE_IDE)
         add_llvm_install_targets(install-${name}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62176.200410.patch
Type: text/x-patch
Size: 767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190521/82cdda41/attachment.bin>