[PATCH] D62111: Tweaks for setting CMAKE_LINKER to lld-link

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:15
 
-if(CMAKE_LINKER MATCHES "lld-link\\.exe" OR (WIN32 AND LLVM_USE_LINKER STREQUAL "lld") OR LLVM_ENABLE_LLD)
+if(CMAKE_LINKER MATCHES "lld-link" OR (WIN32 AND LLVM_USE_LINKER STREQUAL "lld") OR LLVM_ENABLE_LLD)
   set(LINKER_IS_LLD_LINK TRUE)
----------------
Not your diff, but is this just setting `LINKER_IS_LLD_LINK` to true when `LLVM_ENABLE_LLD` is true? That seems wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62111/new/

https://reviews.llvm.org/D62111