[PATCH] D62124: [LLD][COFF] Implement /filealign parameter

Mon May 20 21:55:38 PDT 2019

thrimbor added a comment.

In D62124#1509410 <https://reviews.llvm.org/D62124#1509410>, @ruiu wrote:

> Did you personally need this? Or are you adding this just for completeness?
>
> Either case is fine, but I'd like to know what is a use case of this feature.

I didn't need this myself, but the need for it came up during the work of another XboxDev member who worked on adding support for debug extensions to our toolchain targeting the original Xbox (called nxdk), and I decided to try and add this feature. Due to the lack of /filealign-support we currently have a workaround in place: https://github.com/JayFoxRox/nxdk/pull/10/commits/1822465478b04ca18d5544c103bfe743ad47876c#diff-6ffdcfc2a5d215955b49510d4547fc8cR19

Ideally we would be able to have filealign==align (which this patch makes possible, removing the need for the workaround) and be able to choose a small value for this (which would require hooking up /align, which I do plan to do, too) to minimize memory usage (the Xbox only has 64MiB of RAM and there has to be enough left for the application, so our debug extensions aren't allowed to consume much space).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62124/new/

https://reviews.llvm.org/D62124