[PATCH] D62139: Ensuring unique names for JITDylib's
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 19:33:51 PDT 2019
lhames added a comment.
Oh -- I missed that this was passing the name as a std::string by value. This will result in unnecessary string copies. In general for a case like this you would use an llvm::StringRef -- It's a lightweight string reference type. I'll switch to that before committing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62139/new/
https://reviews.llvm.org/D62139
More information about the llvm-commits
mailing list