[PATCH] D62068: [MergeICmps] Preserve the dominator tree.
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 14:31:58 PDT 2019
gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Transforms/Scalar/MergeICmps.cpp:718
+
+ // If the old cmp chain was the function entry, we need to update the function
+ // entry.
----------------
format
================
Comment at: llvm/lib/Transforms/Scalar/MergeICmps.cpp:862
+ auto *DTWP = getAnalysisIfAvailable<DominatorTreeWrapperPass>();
+ DomTreeUpdater DTU(DTWP ? &DTWP->getDomTree() : nullptr, nullptr,
+ DomTreeUpdater::UpdateStrategy::Eager);
----------------
Can you add a comment for the second `nullptr`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62068/new/
https://reviews.llvm.org/D62068
More information about the llvm-commits
mailing list