[PATCH] D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 11:15:52 PDT 2019


Dor1s added a comment.

The change looks good to me, with one minor edit requested.



================
Comment at: compiler-rt/lib/profile/InstrProfiling.c:39
+COMPILER_RT_VISIBILITY void __llvm_profile_set_dumped() {
+  ProfileDumped = 1;
+}
----------------
I think it's better to call `lprofSetProfileDumped` here, just to make sure we keep the implementation at one place, i.e. inside internal `lprofSetProfileDumped` function (even though it's exported as well).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62078/new/

https://reviews.llvm.org/D62078





More information about the llvm-commits mailing list