[PATCH] D62134: MC: Allow getMaxInstLength to depend on the subtarget

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 11:05:57 PDT 2019


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp:26
+  // subtarget, it can be reduced to 8 bytes.
+  MaxInstLength = (TT.getArch() == Triple::amdgcn) ? 12 : 16;
   SeparatorString = "\n";
----------------
I believe it is 20 though:
# GFX10: image_sample_c_d v[16:19], [v8, v9, v10, v11, v12, v13, v14, v15, v16, v17], s[20:27], s[100:103] dmask:0xf dim:SQ_RSRC_IMG_3D ; encoding: [0x16,0x0f,0xa8,0xf0,0x08,0x10,0x25,0x03,0x09,0x0a,0x0b,0x0c,0x0d,0x0e,0x0f,0x10,0x11,0x00,0x00,0x00]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62134/new/

https://reviews.llvm.org/D62134





More information about the llvm-commits mailing list