[PATCH] D61693: Rough out InstCombine::visitFNeg(...)

Mon May 20 09:54:12 PDT 2019

spatel added a comment.

In D61693#1508481 <https://reviews.llvm.org/D61693#1508481>, @cameron.mcinally wrote:

> Ping.

LGTM

> Are we okay with addressing the concerns @lebedev.ri brought up in a different patch? I could file a bug if wanted.

It's definitely a different patch (if we can actually do anything about it). Adding details from the discussion here to the existing code comment would be good as a separate NFC too.

================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:1824

+static Instruction *foldFNegIntoConstant(Instruction &I) {
+  Value *X;
----------------
Would be nice to have a documentation comment for this function that says something like:
This eliminates floating-point negation in either 'fneg' or 'fsub' form by combining into a constant operand.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61693/new/

https://reviews.llvm.org/D61693