[PATCH] D61563: [ELF] Error on relocations to local undefined symbols

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 04:27:02 PDT 2019


grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:1035
+  // them.
+  if (SymIndex != 0 && maybeReportUndefined(Sym, Sec, Rel.r_offset))
     return;
----------------
I.e. this is only for ARM? Should we use a helper there then maybe, like:

(pseudocode)

```
static bool isMarkerSym(Type) {
 if (!Arm)
  return Type == Target->NoneRel;
return SymIndex != 0;
}
```



Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61563/new/

https://reviews.llvm.org/D61563





More information about the llvm-commits mailing list