[PATCH] D62054: [llvm-objdump] Make --disassemble-functions imply -d

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor comment outstanding.

Do you need somebody to commit it for you?



================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test:6
+FileHeader:      
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
----------------
mmpozulp wrote:
> jhenderson wrote:
> > Nit: I'm trying to fight against unnecessary whitespace in these blobs. Reduce the space between the tag and value to the minimum needed for the values to line up within the block i.e:
> > ```
> >   Class:   ELFCLASS64
> >   Data:    ELFDATA2LSB
> >   Type:    ET_REL
> > ​  Machine: EM_X86_64
> > ```
> Should we modify `obj2yaml` to eliminate unnecessary whitespace? I'm an ELF noob so when I made this test case I started with a source (.c) file, compiled to an object (.o) file, and finally ran obj2yaml to generate the yaml file, which seems to always include extra whitespace.
It might be good to do so. I don't know the background behind why it does that. For the record, I quite often copy an existing yaml blob and work from there. You may find that useful going forwards.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test:22
+# CHECK: 0000000000000000 main:
+# CHECK:        0: 90                            nop
----------------
You can use CHECK-NEXT here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62054/new/

https://reviews.llvm.org/D62054