[PATCH] D62055: [ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack

Mon May 20 00:12:14 PDT 2019

MaskRay added a comment.

In D62055#1508038 <https://reviews.llvm.org/D62055#1508038>, @ruiu wrote:

> I'd vote for re-submitting the original patch with a larger alignment to avoid introducing Android-specific ABI to the output, as I said in a different review thread. Is there any problem to do that?

@ruiu To fix the hack isn't impossible, but that would make the code more hacky (D61824 <https://reviews.llvm.org/D61824> and D61825 <https://reviews.llvm.org/D61825>), and some ARM/AArch users (e.g. musl) are not happy. As I described in https://reviews.llvm.org/D62055#1507426, the relevant support is all in place, the nearly zero-overhead workaround in Bionic `crtbegin_{dynamic,static}.o` should be straightforward now. I don't know why we would like to re-introduce the hack and cause churn in the 8.0.1 release.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62055/new/

https://reviews.llvm.org/D62055