[PATCH] D62117: Make replaceSymbol a member function of Symbol.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/ELF/Symbols.h:434
 
-static size_t getSymbolSize(const Symbol &Sym) {
-  switch (Sym.kind()) {
-  case Symbol::CommonKind:
+size_t Symbol::getSymbolSize() const {
+  switch (kind()) {
----------------
MaskRay wrote:
> Consider renaming this since it is now a member function.
I considered that but unfortunately we already have getSize function to return a size attribute of a symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62117/new/

https://reviews.llvm.org/D62117