[PATCH] D61607: Introduce an option to stripPointerCasts to force the same bit pattern
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 18 21:37:19 PDT 2019
arsenm added a comment.
In D61607#1507697 <https://reviews.llvm.org/D61607#1507697>, @aykevl wrote:
> Yes I know it can change the bit pattern. And if it is only about the bit pattern, the name is fine. However, it seems to me that the only difference between `stripPointerCastsSameBitPattern` and `stripPointerCasts` is the AS, which may or may not be relevant to the bit pattern. This is confusing: it isn't clear to me from the name `stripPointerCastsSameBitPattern` whether it may strip any `addrspacecast` that has the same bit pattern.
I think bitcasts between equivalently sized pointers with different address spaces should be allowed, rather than requiring addrspacecast like today, so I'm not sure I would want to specify this is an address space property
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61607/new/
https://reviews.llvm.org/D61607
More information about the llvm-commits
mailing list