[PATCH] D62054: [llvm-objdump] Make --disassemble-functions imply -d

[Mike Pozulp via Phabricator via llvm-commits]

mmpozulp marked an inline comment as done.
mmpozulp added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-implied-by-disassemble-functions.test:6
+FileHeader:      
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
----------------
jhenderson wrote:
> Nit: I'm trying to fight against unnecessary whitespace in these blobs. Reduce the space between the tag and value to the minimum needed for the values to line up within the block i.e:
> ```
>   Class:   ELFCLASS64
>   Data:    ELFDATA2LSB
>   Type:    ET_REL
> ​  Machine: EM_X86_64
> ```
Should we modify `obj2yaml` to eliminate unnecessary whitespace? I'm an ELF noob so when I made this test case I started with a source (.c) file, compiled to an object (.o) file, and finally ran obj2yaml to generate the yaml file, which seems to always include extra whitespace.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62054/new/

https://reviews.llvm.org/D62054