[PATCH] D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 18 06:28:58 PDT 2019


lebedev.ri created this revision.
lebedev.ri added reviewers: RKSimon, craig.topper, spatel.
lebedev.ri added a project: LLVM.
Herald added subscribers: kristof.beyls, t-tye, tpr, dstuttard, javed.absar, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.

https://rise4fun.com/Alive/6bVL

AArch64 is clearly a regression, will need a separate fix
AMDGPU change looks bad either way - `bfe` is not used
X86 changes look neutral-positive, except vector cases, those are clearly regressions


Repository:
  rL LLVM

https://reviews.llvm.org/D62100

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/AArch64/arm64-bitfield-extract.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.ubfe.ll
  test/CodeGen/X86/pr32588.ll
  test/CodeGen/X86/pull-binop-through-shift.ll
  test/CodeGen/X86/rotate-extract-vector.ll
  test/CodeGen/X86/rotate-extract.ll
  test/CodeGen/X86/shift-mask.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62100.200150.patch
Type: text/x-patch
Size: 15387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190518/3b961020/attachment.bin>


More information about the llvm-commits mailing list