[PATCH] D62040: [docs] Add new document on building distributions

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/docs/BuildingADistribution.rst:128
+generating LLVM profiling information to drive Profile-Guided-Optimization. The
+in-tree profiling tests are very limited, and generating the profile takes a
+significant amount of time, however it can have a significant improvement in
----------------
@beanz While you're in a documentation writing mood, I think you'd mentioned wanting to write up tips on creating good PGO sample files and getting good profiling data? :D


================
Comment at: llvm/docs/BuildingADistribution.rst:129
+in-tree profiling tests are very limited, and generating the profile takes a
+significant amount of time, however it can have a significant improvement in
+the performance of the generated binaries.
----------------
I think "but" would read better than "however" here.


================
Comment at: llvm/docs/BuildingADistribution.rst:203
+**LLVM_INSTALL_TOOLCHAIN_ONLY**:BOOL
+  This option defaults to ``Off``, when set to ``On`` it removes many of the
+  LLVM development and testing tools from the default ``install`` target.
----------------
Nit: semicolon instead of comma here.

`LLVM_INSTALL_TOOLCHAIN_ONLY` also prevents libraries from being installed, right?

Is it worth mentioning `LLVM_TOOLCHAIN_TOOLS`, which you need to use to get things to actually install if you're using `LLVM_INSTALL_TOOLCHAIN_ONLY`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62040/new/

https://reviews.llvm.org/D62040