[PATCH] D58260: [INLINER] allow inlining of blockaddresses if sole uses are callbrs

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 16:58:41 PDT 2019


nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/Inline/blockaddress.ll:91
+
+; Triple check that even with a global aggregate whose member is a blockaddress,
+; we still don't inline referred to functions.
----------------
>> It'd be good to add a test case along thes elines where we round trip through an extra global or something?

> Values can be used by Global*s and probably other objects.

Is this just-added-testcase (from L91 to EOF) what was expected?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58260/new/

https://reviews.llvm.org/D58260





More information about the llvm-commits mailing list