[PATCH] D61425: Install import libraries

[Vyacheslav Zakharin via Phabricator via llvm-commits]

vzakhari added inline comments.


================
Comment at: llvm/trunk/cmake/modules/AddLLVM.cmake:688
+              RUNTIME DESTINATION bin
               COMPONENT ${name})
 
----------------
Hi Julien,

With this change you effectively define COMPONENT only for the RUNTIME target.  The LIBRARY and ARCHIVE targets are now added to the Unspecified component.

CMake install documentation is not very robust about this:
install(TARGETS targets... [EXPORT <export-name>]
        [
         [ARCHIVE|LIBRARY|RUNTIME|...]
         [DESTINATION <dir>]
...
         [COMPONENT <component>]
...
        ] [...]

This basically means that COMPONENT option has to be set after each of LIBRARY, ARCHIVE, RUNTIME options.

CMake component based install and CPack cannot work properly after this commit.  Would you please fix it?

Thanks,
Slava


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61425/new/

https://reviews.llvm.org/D61425