[PATCH] D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 11:56:41 PDT 2019


cryptoad updated this revision to Diff 200074.
cryptoad marked 18 inline comments as done.
cryptoad added a comment.

Correcting some code constructs as suggested by Matt:

- using unique_ptr in tests;
- accounting for a potential null `TransferBatch` in `refill`;
- other corrections.

On top of that, adding some comments to justify:

- using extra variables to improve memory access patterns
- the lower limit at which size classes can be released (and a TODO)


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61745/new/

https://reviews.llvm.org/D61745

Files:
  lib/scudo/standalone/CMakeLists.txt
  lib/scudo/standalone/local_cache.h
  lib/scudo/standalone/primary32.h
  lib/scudo/standalone/primary64.h
  lib/scudo/standalone/tests/CMakeLists.txt
  lib/scudo/standalone/tests/primary_test.cc
  lib/scudo/standalone/tests/secondary_test.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61745.200074.patch
Type: text/x-patch
Size: 42599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190517/6e9f166d/attachment-0001.bin>


More information about the llvm-commits mailing list