[PATCH] D62067: [Support] Time profiler: support new PassManager

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D62067#1506714 <https://reviews.llvm.org/D62067#1506714>, @anton-afanasyev wrote:

> In D62067#1506690 <https://reviews.llvm.org/D62067#1506690>, @lebedev.ri wrote:
>
> > I know this is in line with what is done in old-pm, but i find the middle-end names to be very useless.
> >  In particular, why is the actual optimization pass name is always in the description, and the actual timeslice name is always the same generic "Opt???"?
> >  IMHO the actual optimization pass name should be the Name, not Detail.
>
>
> We can change this in a separate commits in both new and old pm.




> Same name "Opt???" makes the same color in a flamechart.

Yes, indeed.
I *believe* it also makes double-clicking on one select *all* the slices with that "Opt???" name.
In other words, how do i group by the pass name?
It can be argued either way which is more important, sure.

> Btw, have you tried Speedscope (https://www.speedscope.app) for visualization? It works better than chrome://tracing, trying to show details in chart boxes.

No, i know it exists, but i didn't try it..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62067/new/

https://reviews.llvm.org/D62067