[PATCH] D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 17 05:15:17 PDT 2019
ruiu added a comment.
LGTM
================
Comment at: lld/trunk/wasm/OutputSections.h:72
+ virtual void writeBody() {}
+
----------------
Could you add a comment as to what this function is supposed to do? E.g.
writeBody writes section contents to `Body` string. You need to call this function before fixing section layout because otherwise section size is not known.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61971/new/
https://reviews.llvm.org/D61971
More information about the llvm-commits
mailing list