[PATCH] D61969: Fix Bugzilla ID 41862 to support checking addresses of disassembled object

Fri May 17 03:32:20 PDT 2019

jhenderson added a comment.

Thanks for working on this! Please remember to check that the bug is not assigned to somebody when you start working on it, and assign it to yourself when you do.

Test case?

In D61969#1505389 <https://reviews.llvm.org/D61969#1505389>, @xerofoify wrote:

> It fails after looking at the code again for the gnu binutils so it would be best to keep them compatible IMO. However merging my if statement together is better through so I
>  keep upload a new patch with the git diff comments as I was just using git format patch before. In addition it seems that there is also the case in binutils of lesser
>  than stop address so that should be added as well so I guess we really do need another if statement.  Let me know if those changes work for you to keep compatibility with 
>  gnu binutils.

I'm not sure I quite follow your comment here. For error messages, I don't think we need to worry about compatibility with GNU, so it's fine if they're different. I think having a single if is all that is needed. I'd expect the patch to be the following:

  if (StartAddress >= StopAddress)
    error("Start address should be less than stop address");

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61969/new/

https://reviews.llvm.org/D61969