[PATCH] D60260: Match types of accumulator and result for llvm.experimental.vector.reduce.fadd/fmul

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 03:22:00 PDT 2019


sdesmalen added a comment.

In D60260#1499005 <https://reviews.llvm.org/D60260#1499005>, @nikic wrote:

> This looks good, but please also update existing tests that specify three types in the intrinstic name. Here's ones I found:
>
> - test/CodeGen/X86/haddsub.ll
> - test/CodeGen/X86/vector-reduce-fadd-fast.ll
> - test/CodeGen/X86/vector-reduce-fadd.ll
> - test/CodeGen/X86/vector-reduce-fmul-fast.ll
> - test/CodeGen/X86/vector-reduce-fmul.ll


Good spot! I've updated these tests now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60260/new/

https://reviews.llvm.org/D60260





More information about the llvm-commits mailing list