[PATCH] D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: MinGW/Options.td:61
 def pdb: S<"pdb">, HelpText<"Specify output PDB debug information file">;
+def pdb_eq: J<"pdb=">, Alias<pdb>;
 def Xlink : J<"Xlink=">, MetaVarName<"<arg>">,
----------------
mstorsjo wrote:
> ruiu wrote:
> > mstorsjo wrote:
> > > dmajor wrote:
> > > > Should the new behavior be advertised in the HelpText or a doc somewhere?
> > > Hmm, yes, ideally. I don't think there's much other general usage docs for the MinGW driver, so I guess it has to be squeezed into the HelpText here. I'd document it on my page for my MinGW distribution at least, for general usage of PDBs in a MinGW context (for the combination of passing `-gcodeview` to the compiler, and this option to the linker).
> > > 
> > > Maybe `HelpText<"Specify output PDB debug information file. Defaults to the output filename, with a pdb suffix, if given an empty argument.">`? Or can you come up with a more concise way of describing it?
> > Other help messages don't end with a full stop, so I'd try to explain it in a single sentence rather than two sentences.
> What about `Output PDB debug info file, chosen implicitly if the arguent is empty`? That's pretty short, no full stops, and still conveys the main point.
Sounds good!


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62004/new/

https://reviews.llvm.org/D62004