[PATCH] D61918: [DAGCombiner] visitShiftByConstant(): drop bogus(?) signbit check
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 17 00:40:23 PDT 2019
lebedev.ri added a comment.
In D61918#1502732 <https://reviews.llvm.org/D61918#1502732>, @lebedev.ri wrote:
> In D61918#1502313 <https://reviews.llvm.org/D61918#1502313>, @craig.topper wrote:
>
> > This logic was copied from canShiftBinOpWithConstantRHS in InstCombineShifts.cpp
>
>
> Aha, that makes sense. Posted D61938 <https://reviews.llvm.org/D61938>.
Does this look good now that this fix for the origin of this code is accepted?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61918/new/
https://reviews.llvm.org/D61918
More information about the llvm-commits
mailing list