[PATCH] D62040: [docs] Add new document on building distributions
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 17 00:23:20 PDT 2019
hans added a comment.
Interesting! I didn't know about most of this.
> I want to discourage people from using the install target when building distributions because I think that if you are building a distribution you should be conscious of exactly what goes into it. The install-distribution target does that in a much cleaner interface than the install target provides.
But the install target is kind of a standard cmake thing; wouldn't it be better if we made that target good? That's also what the cmake "package" target uses, which is what we use to build the Windows installer.
================
Comment at: llvm/docs/BuildingADistribution.rst:202
+**LLVM_INSTALL_TOOLCHAIN_ONLY**:BOOL
+ This option defaults to ``On``, when set to ``Off`` it includes many of the
+ LLVM development and testing tools in the default ``install`` target. This is
----------------
I thought it defaults to OFF?
llvm/CMakeLists.txt:221:option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62040/new/
https://reviews.llvm.org/D62040
More information about the llvm-commits
mailing list