[PATCH] D62034: compiler-rt/lib/builtins: s/#include <windows.h>/#include <Windows.h>/g to match proper case.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 23:12:00 PDT 2019


mstorsjo added a comment.

Yes, MinGW headers are all lowercase.

And the Windows SDK, where the file is spelled with a capital W, isn't self-consistent (some headers include others with a different capitalization than the files actually are stored with), so to use the official Windows SDK on a case sensitive file system, you need some sort of case fixup anyway. (Or did that change very recently?) And in that case, making it all lowercase is the simplest, which also happens to match the MinGW headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62034/new/

https://reviews.llvm.org/D62034





More information about the llvm-commits mailing list