[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 16 19:07:39 PDT 2019
hubert.reinterpretcast added a comment.
I think this is pretty much there. One last issue for this patch, and then I think we can leave further tweaks for later patches.
================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:115
+ if (SymEntPtr->StorageClass & 0x80)
+ return make_error<StringError>(
+ "XCOFF object file with debug information not yet supported",
----------------
I'm not sure what asserting on a asserts-enabled build but generating a hard-error on a release build buys us. If we are okay with a hard error, then we can just go with it for all builds. If we are not okay with a hard error, then we don't want the debug build to trip either (and a TODO comment with some recovery path is the right answer).
Note that `llvm/test/tools/llvm-readobj/Inputs/xcoff-basic.o` has such symbols.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61532/new/
https://reviews.llvm.org/D61532
More information about the llvm-commits
mailing list