[PATCH] D62033: Change llvm_add_library to always use name for static libraries

Thu May 16 15:55:55 PDT 2019

winksaville added a comment.

In D62033#1505561 <https://reviews.llvm.org/D62033#1505561>, @beanz wrote:

> Why are the clang libraries being built `STATIC` and `SHARED`?
>
> We need to understand the problem you are trying to solve, because this doesn't seem like the right solution.

Building STATIC and SHARED libraries is a capability already available in llvm_add_library (see recursive call at line 451)
and this patch fixes the bug I found while using that capability to create D61804 <https://reviews.llvm.org/D61804> "Support building shared and static libraries simultaneously"
for  clang. As it turns out your solution was better, D61909 <https://reviews.llvm.org/D61909>, so D61804 <https://reviews.llvm.org/D61804> was abandoned.

This patch is a subset of D61804 <https://reviews.llvm.org/D61804> that only fixes the bug.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62033/new/

https://reviews.llvm.org/D62033