[PATCH] D61203: [compiler-rt] Fix cmake warnings

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 13:16:13 PDT 2019


smeenai added a comment.

This is a straightforward build system fix, so it should be fine.

The CMP0075 setting has some potential to change configure results. Could you do a clean CMake run before and after this patch and verify that the CMakeCache.txt files are the same? If so, this LGTM. (That's only testing for your configuration, so it's not comprehensive and there might be configuration changes on other platforms, but it at least gets us some basic sanity checking.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61203/new/

https://reviews.llvm.org/D61203





More information about the llvm-commits mailing list