[PATCH] D62014: [X86] Support .reloc *, R_{386,X86_64}_NONE, *

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 12:56:54 PDT 2019


pcc added inline comments.


================
Comment at: lib/Target/X86/MCTargetDesc/X86FixupKinds.h:17
 enum Fixups {
-  reloc_riprel_4byte = FirstTargetFixupKind, // 32-bit rip-relative
+  reloc_NONE = FirstTargetFixupKind, // 32-bit rip-relative
+  reloc_riprel_4byte, // 32-bit rip-relative
----------------
The comment isn't accurate.

Should this be a generic fixup kind (i.e. MCFixupKind)? It seems that both ELF and COFF support it on all targets.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62014/new/

https://reviews.llvm.org/D62014





More information about the llvm-commits mailing list