[llvm] r360917 - [ORC] Use inline friend definitions for SymbolStringPtr operators.
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Thu May 16 10:20:17 PDT 2019
Author: lhames
Date: Thu May 16 10:20:17 2019
New Revision: 360917
URL: http://llvm.org/viewvc/llvm-project?rev=360917&view=rev
Log:
[ORC] Use inline friend definitions for SymbolStringPtr operators.
Modified:
llvm/trunk/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h?rev=360917&r1=360916&r2=360917&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h Thu May 16 10:20:17 2019
@@ -50,9 +50,6 @@ private:
class SymbolStringPtr {
friend class SymbolStringPool;
friend struct DenseMapInfo<SymbolStringPtr>;
- friend bool operator==(const SymbolStringPtr &LHS,
- const SymbolStringPtr &RHS);
- friend bool operator<(const SymbolStringPtr &LHS, const SymbolStringPtr &RHS);
static SymbolStringPool::PoolMapEntry Tombstone;
@@ -92,6 +89,21 @@ public:
StringRef operator*() const { return S->first(); }
+ friend bool operator==(const SymbolStringPtr &LHS,
+ const SymbolStringPtr &RHS) {
+ return LHS.S == RHS.S;
+ }
+
+ friend bool operator!=(const SymbolStringPtr &LHS,
+ const SymbolStringPtr &RHS) {
+ return !(LHS == RHS);
+ }
+
+ friend bool operator<(const SymbolStringPtr &LHS,
+ const SymbolStringPtr &RHS) {
+ return LHS.S < RHS.S;
+ }
+
private:
SymbolStringPtr(SymbolStringPool::PoolMapEntry *S)
@@ -103,18 +115,6 @@ private:
SymbolStringPool::PoolMapEntry *S = nullptr;
};
-inline bool operator==(const SymbolStringPtr &LHS, const SymbolStringPtr &RHS) {
- return LHS.S == RHS.S;
-}
-
-inline bool operator!=(const SymbolStringPtr &LHS, const SymbolStringPtr &RHS) {
- return !(LHS == RHS);
-}
-
-inline bool operator<(const SymbolStringPtr &LHS, const SymbolStringPtr &RHS) {
- return LHS.S < RHS.S;
-}
-
inline SymbolStringPool::~SymbolStringPool() {
#ifndef NDEBUG
clearDeadEntries();
More information about the llvm-commits
mailing list