[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. With one comment that I will leave to you for what you think is best.



================
Comment at: include/clang/Driver/Options.td:2145
+  Flags<[DriverOption,CC1Option]>,
+  HelpText<"Allow use of CMSE instructions (ARM only)">;
 
----------------
dmgreen wrote:
> Should this say something about compiling for secure state?
Maybe "Enables generation of secure code for CMSE (Armv8-M Security Extensions)".

I meant to say that non-secure code can still be compiled without this flag, and can use some cmse features (as far as I understand). Its the secure side that needs this flag to do the clearing of registers and whatnot.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59879/new/

https://reviews.llvm.org/D59879