[PATCH] D59879: [ARM][CMSE] Add commandline option and feature macro

[Javed Absar via Phabricator via llvm-commits]

javed.absar marked 4 inline comments as done.
javed.absar added inline comments.


================
Comment at: lib/Basic/Targets/ARM.cpp:438
+    } else if (Feature == "+8msecext") {
+      if ((CPUProfile != "M" && CPUProfile != "B") || ArchVersion != 8) {
+        Diags.Report(diag::err_target_unsupported_mcmse) << CPU;
----------------
snidertm wrote:
> dmgreen wrote:
> > snidertm wrote:
> > > How does CPUProfile get a value of "B"? I thought any Cortex-M processor would set CPUProfile to "M". Is CMSE available on a processor besides Cortex-m33?
> > "B" was going to be a very old name for v8m-baseline, looks like this one was never cleaned up when that was changed. You can drop the != "B" check.
> Do all v8 profile == 'M' processor variants support security extensions?
Yes


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59879/new/

https://reviews.llvm.org/D59879