[PATCH] D61973: [AArch64] Support .reloc *, R_AARCH64_NONE, *

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

To get back to this patch. I think the non-bigendian comments I made on D61992 <https://reviews.llvm.org/D61992> apply here as well. Generally looks good. Will be worth checking that the format is ELF before accepting R_AARCH64_NONE.

I checked what GNU as does about the ILP32 status as the code R_AARCH64_P32_NONE is also defined to be 0. Having said that it seems like GNU as will only accept R_AARCH64_NONE in both ilp32 and ilp64 modes and won't accept R_AARCH64_P32_NONE so I think what we have here is fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61973/new/

https://reviews.llvm.org/D61973