[PATCH] D61941: [llvm-objdump]Improve testing of some switches #1

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objdump/section-filter.test:66
+
+## Show non-executable sections are not disassembled even if specified,
+## and that only the specified executable sections are disassembled.
----------------
jhenderson wrote:
> MaskRay wrote:
> > objdump -d -j.data  dumps non-executable sections.
> Thanks. I'll file a bug for this.
See https://bugs.llvm.org/show_bug.cgi?id=41897.


================
Comment at: test/tools/llvm-objdump/section-filter.test:213
+
+## Test that an unknown section name causes all section output to be suppressed.
+# RUN: llvm-objdump %t.h.elf -h --section foobar \
----------------
jhenderson wrote:
> MaskRay wrote:
> > Apparently we missed a GNU objdump warning...
> Yes, I agree. I'll file a bug for this too.
See https://bugs.llvm.org/show_bug.cgi?id=41898.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61941/new/

https://reviews.llvm.org/D61941