[PATCH] D61941: [llvm-objdump]Improve testing of some switches #1

Thu May 16 03:16:45 PDT 2019

grimar added a comment.

In D61941#1504405 <https://reviews.llvm.org/D61941#1504405>, @jhenderson wrote:

> In D61941#1504329 <https://reviews.llvm.org/D61941#1504329>, @grimar wrote:
>
> > I only have a minor comment (inlined).
> >
> > Out of curiosity are you doing some code coverage check on the llvm-objdump to find the places uncovered?
> >  Asking because I did that few times for LLD and this gave interesting results that time (IMO). I added many test cases and found few interesting bugs and a dead code pieces.
> >  (i.e. if not - I can try to do that and share the results).
>
>
> I've not been doing code coverage checks as such, but I have been inspecting the code to see what behaviour each feature has (and sometimes cross-referencing with GNU). A number of the test cases in this and the following patches that I'm still preparing are based on an internal test suite we have for a proprietary tool.

I see.
I am curious to run it. For LLD I used out test cases set as a base. I.e. idea was to check which code is covered by our tests. I think it should fit nicely for tools like this one too.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61941/new/

https://reviews.llvm.org/D61941