[PATCH] D61993: [llvm-objcopy] Add file names to error messages
Seiya Nuta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 15 23:31:39 PDT 2019
seiya added a comment.
We need to remove unwrapOrError in the file parser [1] as well to print the file name in parsing errors. Removing unwrapOrError and return Error instead sounds straightforward to me but it could make the code messy. I'd like to hear your comments.
[1]: https://github.com/llvm/llvm-project/blob/4669cf27508ba00274367d62b295e1a7ca20c7ba/llvm/tools/llvm-objcopy/ELF/Object.cpp#L1119
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61993/new/
https://reviews.llvm.org/D61993
More information about the llvm-commits
mailing list